refactor: group response tags, use let-else in proto handlers - #129
Merged
Conversation
connection.rs: - merged identical ResponseTag arms with `|` patterns: Get | PopResult | HGetResult (all: Value → Bulk/Null + WrongType) HExistsResult | SIsMemberResult (both: Bool → Integer + WrongType) LenResultOom | HSetResult (both: Len → Integer + WrongType + OOM) ArrayResult | HValsResult (both: Array → Array of Bulk + WrongType) - added section comments for vector and protobuf response groups concurrent_handler.rs: - replaced match-on-Option/Result patterns with let-else for schema registry access (5 match→let Some, 4 match→let Ok)
kacy
added a commit
that referenced
this pull request
Feb 19, 2026
connection.rs: - merged identical ResponseTag arms with `|` patterns: Get | PopResult | HGetResult (all: Value → Bulk/Null + WrongType) HExistsResult | SIsMemberResult (both: Bool → Integer + WrongType) LenResultOom | HSetResult (both: Len → Integer + WrongType + OOM) ArrayResult | HValsResult (both: Array → Array of Bulk + WrongType) - added section comments for vector and protobuf response groups concurrent_handler.rs: - replaced match-on-Option/Result patterns with let-else for schema registry access (5 match→let Some, 4 match→let Ok)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
summary
ResponseTagarms inresolve_shard_responseusing|patterns. tags with the same response shape (e.g. Get/PopResult/HGetResult all extract Value→Bulk) now share a single match armmatch engine.schema_registry() { Some(r) => r, None => return ... }patterns with idiomaticlet-elseacross all 5 registry accesses and 4 RwLock read/write guardswhat was tested
cargo build -p ember-server --features grpc,vector,protobuf— clean buildcargo test -p ember-server --features grpc,vector,protobuf— all 43 tests pass